WIP: Visual regression tests #303
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustaphe
force-pushed
the
visualregressiontests
branch
from
0aa4706 to
93e2c2b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 82.87% 82.89% +0.02%
==========================================
Files 21 22 +1
Lines 905 912 +7
==========================================
+ Hits 750 756 +6
- Misses 155 156 +1 ☔ View full report in Codecov by Sentry. |
|
There we go. We could probably come back to this before we make any big changes (like #161) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea to solve #78 , using VisualRegressionTests.jl
Not ready or even sure if it's that useful, but I wanted to see if I could get CI to collaborate.
Also needed an option to render without transparency, which should probably be implemented either way.